Convert whitespace string in test node name to '_' to avoid loganalyzer init issue#1747
Closed
wangxin wants to merge 1 commit intosonic-net:masterfrom
wangxin:fix-loganalyzer-init
Closed
Convert whitespace string in test node name to '_' to avoid loganalyzer init issue#1747wangxin wants to merge 1 commit intosonic-net:masterfrom wangxin:fix-loganalyzer-init
wangxin wants to merge 1 commit intosonic-net:masterfrom
wangxin:fix-loganalyzer-init
Conversation
…er init issue For pytest parameterized test case, if the param value has whitespace in its param value, the loganalyzer init command line will fail because the whitespaces confues loganalyzer from parsing the command line arguments. The fix is to convert all whitespaces in test node name to '_'. Loganalyzer will use the new test node name in run_id as test case identifier. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Contributor
|
retest vsimage please |
Collaborator
Author
|
@daall How can I trigger a vsimage retest? |
3 tasks
lguohan
approved these changes
Jun 10, 2020
neethajohn
approved these changes
Jun 10, 2020
3 tasks
Collaborator
Author
|
This issue is better addressed by #1754. I am closing this one. |
4 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule update for sonic-utilties ``` 48035d75 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09a Fix log_ssd_health hang issue (sonic-net#1904) ac9c4254 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417a disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
For pytest parameterized test case, if the param value has whitespace in its param
value, the loganalyzer init command line will fail because the whitespaces confues
loganalyzer from parsing the command line arguments.
The fix is to convert all whitespaces in test node name to '_'. Loganalyzer will use
the new test node name in run_id as test case identifier.
Type of change
Approach
What is the motivation for this PR?
For pytest parametrized test cases, if param value has whitespace in it, then loganalyzer init will fail with exception like below:
The loganalyzer command line is confused by the whitespace and can not parse arguments properly:
python /tmp/loganalyzer.py --action init --run_id test_portstat_clear[portstat -c].2020-06-08-13:04:17This PR is to fix this issue.
How did you do it?
Convert all the whitespace in test node name to '_'.
How did you verify/test it?
Test run a parametrized pytest case with whitespace in param values.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation